Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/2625/9/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: Line 27: _in_json > Remove Done http://gerrit.cloudera.org:8080/#/c/2625/9/tests/hs2/test_json_endpoints.py File tests/hs2/test_json_endpoints.py: Line 27: _get_in_flight_queries > can you make this _get_json_queries and have this return the full output? t Done Line 27: > we use 2 spaces for indentation in python, here and below. Done Line 48: self._get_in_flight_queries > if you change the fn to get all the output, then you'll have to select out I'm a little confused by what you mean - there isn't an executing_queries or waiting_queries endpoint, its all just in_flight_queries and then each query has 'executing' and 'waiting' values defined on it, so I'm checking the executing/waiting status below with 'assert in_flight_queries[0]["executing"]' etc. Line 49: in_flight_queries > add assert then length of this list is 1 Done Line 60: fetch_results_req > can you remove this line? maxRows is a required field with no default in the TFetchResultsReq, so we have to set it. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
