Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2625/8/tests/custom_cluster/test_json_endpoints.py File tests/custom_cluster/test_json_endpoints.py: Line 65: self.check_in_flight_query(impalad, False) > You should be able to do this more deterministically if you drive the query I don't see how using hs2 fixes the problem of idle_query_timeout being flaky, since we would still be relying on the timing of the impalad process. Dan may be right that its not necessary to do the idle_query_timeout check. The problem with not having a custom cluster is that other concurrently running tests may have queries that would show up in in_flight_queries. We could get around that by just checking for the existence of the query we're expecting in in_flight_queries, and not that its the only query, but that makes the test a little less clean. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
