Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#/c/2625/9/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: Line 27: _in_json Remove http://gerrit.cloudera.org:8080/#/c/2625/9/tests/hs2/test_json_endpoints.py File tests/hs2/test_json_endpoints.py: Line 27: _get_in_flight_queries can you make this _get_json_queries and have this return the full output? then we can check the other new parameters as well. Then a brief comment like: """Returns the json output of the /queries page from the impalad web UI at http_addr.""" Line 27: we use 2 spaces for indentation in python, here and below. Line 48: self._get_in_flight_queries if you change the fn to get all the output, then you'll have to select out ["in_flight_queries"] here, but then you can assert num_in_flight_queries is 1, num_executing_queries is 1, num_waiting_queries is 0. Line 49: in_flight_queries add assert then length of this list is 1 Line 60: fetch_results_req can you remove this line? Line 66: assert num_in_flight_queries is 1, num_executing_queries is 0, num_waiting_queries is 1. Line 72: assert len(self._get_in_flight_queries(http_addr)) == 0 assert num_in_flight_queries is 0, num_executing_queries is 0, num_waiting_queries is 0. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
