Dan Hecht has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web 
UI
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2625/8/tests/custom_cluster/test_json_endpoints.py
File tests/custom_cluster/test_json_endpoints.py:

Line 65:     self.check_in_flight_query(impalad, False)
> You can fix the latter problem by adding the @pytest.mark.execute.serially 
I think we have a test for idle query timeout. you could look to see what that 
tests does, and maybe we should consider augmenting that test to check the 
waiting state so that we don't duplicate timing sensitive test code.


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: Yes

Reply via email to