Henry Robinson has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2625/8/tests/custom_cluster/test_json_endpoints.py File tests/custom_cluster/test_json_endpoints.py: Line 65: self.check_in_flight_query(impalad, False) > I don't see how using hs2 fixes the problem of idle_query_timeout being fla You can fix the latter problem by adding the @pytest.mark.execute.serially decorator, I think? You're right about the idle_query_timeout - I misunderstood what check_in_flight_query was supposed to do (i.e. thought the race was against the query finishing, not going idle). Presumably you can at least check that the query goes idle eventually, with some reasonable timeout. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
