[ 
https://issues.apache.org/jira/browse/JENA-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152392#comment-17152392
 ] 

David Cook commented on JENA-909:
---------------------------------

I'm not really interested in Fuseki anymore as it's not scalable, but I'll add 
some quick comments about that Dockerfile.0.

 
 # If you can run Fuseki as a non-root user, you should do that. 
 # Don't bother with the VOLUME instructions. People can specify their own 
volumes at run-time (whether that's with "docker run", docker-compose, or 
whatever)
 # Note that openjdk:8 is both a build and runtime environment, so good for dev 
but not really ideal for just running Fusek

 

Actually, it looks like you're trying to provide people with a Dockerfile that 
will get them a ready made Fuseki... you might consider just hosting a Docker 
image for them on your project's Github: 
[https://docs.github.com/en/actions/language-and-framework-guides/publishing-docker-images]

If you do that, then you could also get rid of those REPO, JAR_URL, and curl 
bits, and just copy the JAR from your Docker build environment. It would make 
for a much simpler Dockerfile. 

 

Anyway, that's just my 2 cents.

> Create Docker launcher for Fuseki
> ---------------------------------
>
>                 Key: JENA-909
>                 URL: https://issues.apache.org/jira/browse/JENA-909
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: Fuseki
>            Reporter: Andy Seaborne
>            Priority: Major
>         Attachments: Dockerfile.0, image-2019-10-02-22-24-12-723.png, 
> log4j.properties
>
>
> Provide a Docker launcher and setup documentation for  Fuseki2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to