vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181640115
##########
src/components/src/main/java/org/apache/jmeter/visualizers/SearchTextExtension.java:
##########
@@ -244,11 +244,11 @@ public interface ISearchTextExtensionProvider {
*/
public static class JEditorPaneSearchProvider implements
ISearchTextExtensionProvider {
- private static volatile int LAST_POSITION_DEFAULT = 0;
+ private static final int LAST_POSITION_DEFAULT = 0;
Review Comment:
`LAST_POSITION_DEFAULT` was never modified, and it was `private`.
So it should be safe to make it `final`.
I `volatile` was a typo there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
