[GitHub] [jmeter] vlsi commented on a diff in pull request #5873: Add errorprone verifications

[via GitHub]

vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181642020


##########
src/core/src/main/java/org/apache/jmeter/gui/action/AbstractAction.java:
##########
@@ -102,7 +102,6 @@ protected boolean popupCheckExistingFileListener(HashTree 
tree) {
                             return false;
                         }
                     case ASK:
-                    default:

Review Comment:
   The removal of `default fo enums` is indeed the most controversial changes 
here.
   However, in this case, the switch goes over `private enum`:
   
   ```java
       private enum ActionOnFile {
           APPEND,
           DELETE,
           ASK
       }
   ```
   
   So it is clear there are only three possibilities, so the default can be 
omitted.
   
   At the same time, if some of enum cases are missing, the compilation would 
fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org