[ 
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917362#action_12917362
 ] 

Eugen Paraschiv commented on MAHOUT-480:
----------------------------------------

I fully understand your concern about inconsistent state, especially from a 
conceptual point of view. I will open JIRA issues for mahout-math, 
mahout-examples and mahout-utils and will provide similar patches for them if 
that is OK. 
>From the API perspective, this kind of cross cutting concern is less of a 
>problem, as the guava checks are perfectly aligned with the manual checks that 
>are in place now, meaning that the type of exception thrown is the same, so 
>incremental changes are less of a problem. 
So, now that mahout-core is covered, please tell me how I should go about 
creating the other JIRA issues so that I can continue with this. 
Thanks. 


> Replace manual precondition checking with Precondition utility class from 
> Guava
> -------------------------------------------------------------------------------
>
>                 Key: MAHOUT-480
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-480
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Clustering
>    Affects Versions: 0.3
>            Reporter: Eugen Paraschiv
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will 
> affect the following classes: 
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to