[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917380#action_12917380
]
Ted Dunning commented on MAHOUT-480:
------------------------------------
Thanks Sean.
I have the same preference as you do. Argument checking is argument checking
and null pointer checking in the code is null pointer checking. The
distinction is (slightly) nice to preserve. On the other hand, I would
prioritize ease of reading of the exception type, but only if somebody showed me
code that was significantly easier to read.
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.4
>
> Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
