[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917376#action_12917376
]
Ted Dunning commented on MAHOUT-480:
------------------------------------
I agree that leaving out math for now is a good idea.
Has anybody finished checking my patch?
SHould I commit it anyway?
Eugen,
I don't think it is so bad to change the type of exception if it still makes
sense. Thus, changing an IllegalArgumentException to a NullPointerException
isn't such a bad thing if it makes the code easier to read. It is officially
an API change, but a fairly benign one.
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.4
>
> Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
