[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Dunning updated MAHOUT-480:
-------------------------------
Attachment: MAHOUT-480.patch
Eugen,
I think that there were half a dozen errors in your conversions and at least
one error in the original code. Your patch also had some problems being
applied on 3 files, probably due to recent commits.
I updated the patch to apply cleanly and I have reviewed all 93 files that you
changed, correcting the following kinds of items:
- some tests were not negated correctly
- some of the original checks were backwards
- when data is included in the message, printf syntax should be used to avoid a
string construction if the precondition holds
- code should use Mahout style
Can you review this revised patch?
Also, it is good to keep the same name on the file so that JIRA can see earlier
versions and deprecate them. This can be very important on projects like
Hadoop where patches are reviewed automatically.
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
