[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917377#action_12917377
]
Sean Owen commented on MAHOUT-480:
----------------------------------
Ted I have the patch locally and have added to it as well as fixed a few more
typos. I can commit shortly.
This is a very small point of preference, not one I would insist on, but I like
IllegalArgumentException for when you've checked an argument for null and found
it to be null, and it can't be. It is perhaps more explicit -- the problem is a
bad argument. The description can say what is null. NPE always causes me to
guess that there was a developer error inside the library at first glance.
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.4
>
> Attachments: MAHOUT-480.patch, MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
