[
https://issues.apache.org/jira/browse/MAHOUT-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugen Paraschiv updated MAHOUT-480:
-----------------------------------
Attachment: MAHOUT-480_v3.patch
The MAHOUT-480_v3.patch contains fixes for all of the mahout-core condition
checking that was previously done by hand. A few notes:
- some of the checks are verifying multiple independent conditions on one
single line; I left most of those as they were, but they should really be
broken into independent checks - I can do that after this patch is integrated
- the guava Preconditions class has more specialized methods for checking
various types of conditions; I only used Preconditions.checkArgument() so that
the exact type of exception thrown doesn't change (for example some of the
other methods throw NullPointerException instead of IllegalArgumentException)
> Replace manual precondition checking with Precondition utility class from
> Guava
> -------------------------------------------------------------------------------
>
> Key: MAHOUT-480
> URL: https://issues.apache.org/jira/browse/MAHOUT-480
> Project: Mahout
> Issue Type: Improvement
> Components: Clustering
> Affects Versions: 0.3
> Reporter: Eugen Paraschiv
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 0.5
>
> Attachments: MAHOUT-480_v3.patch
>
>
> Replace manual precondition checking with the Precondition class. This will
> affect the following classes:
> FileDataModel
> MemoryDiffStorage
> SlopeOneRecommender
> FileDiffStorage
> AbstractJDBCDiffStorage
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
