----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46410 -----------------------------------------------------------
Can we make 'master' be a pointer in the nested Http class instead of a reference? This has been the pattern we've followed for nested classes. src/master/http.cpp <https://reviews.apache.org/r/22832/#comment81791> if (credential.principal() == username && credential.secret() == password) { } - Benjamin Hindman On June 20, 2014, 7:45 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 7:45 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/master/http.cpp 5d86976 > src/master/master.hpp b56e9f4 > src/master/master.cpp dcf28ad > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
