----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47156 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/22832/#comment82743> nit: watch the tabs/spaces here :) src/master/http.cpp <https://reviews.apache.org/r/22832/#comment82745> would you mind changing the indent here to match the lines above? src/master/http.cpp <https://reviews.apache.org/r/22832/#comment82746> how long do you expect this call to take? ie, will the client timeout waiting for a response? should this dispatch the request to the master instead and return Accepted()? src/slave/slave.hpp <https://reviews.apache.org/r/22832/#comment82747> is this change just for symmetry with Master::Http? src/tests/shutdown_tests.cpp <https://reviews.apache.org/r/22832/#comment82748> our test methods usually have capital initials: TEST_F(ShutdownTest, ShutdownEndpoint) src/tests/shutdown_tests.cpp <https://reviews.apache.org/r/22832/#comment82751> i think each of these test cases should be a different test. src/tests/shutdown_tests.cpp <https://reviews.apache.org/r/22832/#comment82749> you can also use OK().status (which is more descriptive) src/tests/shutdown_tests.cpp <https://reviews.apache.org/r/22832/#comment82750> also test with authorization header and bad credentials? - Dominic Hamon On July 1, 2014, 3:46 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 3:46 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/Makefile.am 12d84bf > src/master/http.cpp 5d86976 > src/master/master.hpp 5fef354 > src/master/master.cpp 474014b > src/slave/http.cpp cd7f692 > src/slave/slave.hpp 605ee4a > src/slave/slave.cpp f42ab60 > src/tests/shutdown_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
