----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47417 -----------------------------------------------------------
Looks great! I just wonder if we should also allow /shutdown to be called on an unauthenticated cluster (no --credentials). src/master/http.cpp <https://reviews.apache.org/r/22832/#comment83159> Does this mean that the /shutdown API only works when authentication is enabled (or at least credentials are provided)? What if I just want to /shutdown on my local test cluster? Shouldn't there be a way to allow /shutdown without authentication? src/master/http.cpp <https://reviews.apache.org/r/22832/#comment83160> Can we get some more descriptive error strings, please? ("Mesos master" everywhere may not be descriptive enough when debugging) src/master/http.cpp <https://reviews.apache.org/r/22832/#comment83162> Please end your comment with punctuation. src/slave/slave.hpp <https://reviews.apache.org/r/22832/#comment83156> Why did the const Slave& have to become a Slave* too? - Adam B On July 7, 2014, 1:59 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 1:59 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/Makefile.am e3ff6d7 > src/master/http.cpp 5d86976 > src/master/master.hpp 5fef354 > src/master/master.cpp 251b699 > src/slave/http.cpp cd7f692 > src/slave/slave.hpp 605ee4a > src/slave/slave.cpp f42ab60 > src/tests/shutdown_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
