> On July 1, 2014, 11:04 p.m., Dominic Hamon wrote: > > src/slave/slave.hpp, line 324 > > <https://reviews.apache.org/r/22832/diff/2/?file=622206#file622206line324> > > > > is this change just for symmetry with Master::Http?
Yes, this change is just for consistency > On July 1, 2014, 11:04 p.m., Dominic Hamon wrote: > > src/master/http.cpp, line 649 > > <https://reviews.apache.org/r/22832/diff/2/?file=622202#file622202line649> > > > > how long do you expect this call to take? ie, will the client timeout > > waiting for a response? should this dispatch the request to the master > > instead and return Accepted()? I put on comment for this to be changed in a future patch - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47156 ----------------------------------------------------------- On July 7, 2014, 8:59 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 8:59 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/Makefile.am e3ff6d7 > src/master/http.cpp 5d86976 > src/master/master.hpp 5fef354 > src/master/master.cpp 251b699 > src/slave/http.cpp cd7f692 > src/slave/slave.hpp 605ee4a > src/slave/slave.cpp f42ab60 > src/tests/shutdown_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
