----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46506 -----------------------------------------------------------
Any ideas how this could be extended to handle OAuth or other http authentication mechanisms? src/master/http.cpp <https://reviews.apache.org/r/22832/#comment81912> Why check frameworkId.isNone() again here? You already returned BadRequest() above, and I don't see any way for frameworkId to have changed since then. src/master/http.cpp <https://reviews.apache.org/r/22832/#comment81913> Just use find() to find only the first instance of ':', and then you can use substr() to get your username and password (can include ':'s). src/master/http.cpp <https://reviews.apache.org/r/22832/#comment81926> Check for credentials.isSome() before calling get()? src/master/http.cpp <https://reviews.apache.org/r/22832/#comment81936> Check credential.has_secret()? src/master/master.hpp <https://reviews.apache.org/r/22832/#comment81937> No more const. :( Can you give us a quick explanation why? (Master::removeFramework() is not const?) - Adam B On June 20, 2014, 12:45 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 12:45 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/master/http.cpp 5d86976 > src/master/master.hpp b56e9f4 > src/master/master.cpp dcf28ad > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
