> On June 24, 2014, 10:03 a.m., Adam B wrote: > > src/master/master.hpp, line 422 > > <https://reviews.apache.org/r/22832/diff/1/?file=614321#file614321line422> > > > > No more const. :( > > Can you give us a quick explanation why? (Master::removeFramework() is > > not const?)
No removeFramework is not const :( - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46506 ----------------------------------------------------------- On July 1, 2014, 10:46 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22832/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 10:46 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till > Toenshoff. > > > Bugs: MESOS-1390 > https://issues.apache.org/jira/browse/MESOS-1390 > > > Repository: mesos-git > > > Description > ------- > > HTTP Authenticated '/shutdown' endpoint for shutting down a running framework > > > Diffs > ----- > > src/Makefile.am 12d84bf > src/master/http.cpp 5d86976 > src/master/master.hpp 5fef354 > src/master/master.cpp 474014b > src/slave/http.cpp cd7f692 > src/slave/slave.hpp 605ee4a > src/slave/slave.cpp f42ab60 > src/tests/shutdown_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/22832/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
