> On April 2, 2015, 6:40 p.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, lines 363-367 > > <https://reviews.apache.org/r/32694/diff/3/?file=912579#file912579line363> > > > > I'm still not sure why this is best-effort, since we never expect this > > to fail, can we just return its status code? It would be nice to find out > > if this isn't working as expected. > > > > This is even more important for 'perf' if we don't use the existing > > 'sleep' commend, since we don't want to run a long-running 'perf' if we > > can't set the death signal.
Good point. Added a note because prctl here should not return non-zero as the signal passed in is valid. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78697 ----------------------------------------------------------- On April 1, 2015, 7:40 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32694/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 7:40 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2462 > https://issues.apache.org/jira/browse/MESOS-2462 > > > Repository: mesos > > > Description > ------- > > Set death signal for forked du processes for posix/disk isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp > 6e41e2a72cdcf914f2c922fdcb3d267b938e456e > > Diff: https://reviews.apache.org/r/32694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
