----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78526 -----------------------------------------------------------
src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/32694/#comment127345> Rather than depending on ``__linux__``, consider adding ``sys/prctl.h`` to ``AC_CHECK_HEADERS`` and using ``#if HAVE_SYS_PRCTL_H``. src/slave/containerizer/isolators/posix/disk.cpp <https://reviews.apache.org/r/32694/#comment127344> A minor nitpick, but I think that ``#ifdef PR_SET_PDEATHSIG`` would be better than ``#ifdef __linux__`` since other platforms may implement this prctl() in the future. - James Peach On March 31, 2015, 7:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32694/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 7:32 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2462 > https://issues.apache.org/jira/browse/MESOS-2462 > > > Repository: mesos > > > Description > ------- > > Set death signal for forked du processes for posix/disk isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp > 6e41e2a72cdcf914f2c922fdcb3d267b938e456e > > Diff: https://reviews.apache.org/r/32694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
