> On April 1, 2015, 3:32 p.m., James Peach wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 21 > > <https://reviews.apache.org/r/32694/diff/2/?file=911373#file911373line21> > > > > Rather than depending on ``__linux__``, consider adding ``sys/prctl.h`` > > to ``AC_CHECK_HEADERS`` and using ``#if HAVE_SYS_PRCTL_H``.
I searched our code base. We never used `#if HAVE_SOME_HEADER_H` in our code base. I also feels like we should avoid doing that so that our code does not have a dependency to autoconf (we may change that in the future, say, using CMake, bazel, etc.) > On April 1, 2015, 3:32 p.m., James Peach wrote: > > src/slave/containerizer/isolators/posix/disk.cpp, line 363 > > <https://reviews.apache.org/r/32694/diff/2/?file=911373#file911373line363> > > > > A minor nitpick, but I think that ``#ifdef PR_SET_PDEATHSIG`` would be > > better than ``#ifdef __linux__`` since other platforms may implement this > > prctl() in the future. We have `#ifdef __linux__ #include <sys/prctl.h> #endif` for includes, I prefer keeping it the same here:) Thanks for the suggestion anyway! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32694/#review78526 ----------------------------------------------------------- On March 31, 2015, 7:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32694/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 7:32 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2462 > https://issues.apache.org/jira/browse/MESOS-2462 > > > Repository: mesos > > > Description > ------- > > Set death signal for forked du processes for posix/disk isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/posix/disk.cpp > 6e41e2a72cdcf914f2c922fdcb3d267b938e456e > > Diff: https://reviews.apache.org/r/32694/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
