Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83450797
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java
---
@@ -34,15 +34,15 @@
* @param rawMessage
* @return If null is returned, this is treated as an empty list.
*/
- List<T> parse(byte[] rawMessage);
+ List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
--- End diff --
`parseOptional` is the only one called by the parseBolt. This just allows
the parser creator to choose between whether they want to use java 8's optional
to indicate no data is returned or just return null. For a similar reason to
why people had issue changing the interface during this PR, it wasn't ideal to
change the interface when we moved to java 8 back when this was introduced.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
