Sean Schofield wrote: >Oliver, > >Have you examined the Struts build process as I have suggested? It is >pretty simple. What is so complicated about typing 'ant >download-dependencies release' instead of 'ant release'? > >Keep in mind that the 'download-dependencies' target need only be >called once. Actually, it need never be called if you want to get the >jars through your own methods. As you will see in the Struts build >process, you can set up your properties file to use your local copy of >the jar files at any point you wish. So you won't be prevented from >building if there is a problem with the Maven repository. > > That's exactly my point. Of course I can resolve problems with the automatic download manually. But that's me or you or anybody else from the MyFaces team as we all know how our build works. But what about users who checked out MyFaces from the svn repository the first time and then automatic download fails. What should they do? Start an adventure and collect all the required jars from their respective project's download pages? I don't think so.
>Its bad practice to keep the jar files in SVN if you have a reasonable >alternative. A spot check of existing Apache projects reveals that >none of them store jar files in SVN. This includes Struts and Jakarta >Commons. IMO its time for MyFaces to adopt this practice as well. >The download-dependencies target is just an elegant solution used by >Struts to help the user get those jars. > > Who is saying that keeping the jar files in SVN is bad practice? I'm open to adopt best practices from other projects. But removing the required libs from the repository is no best practice to me, it's the opposite. You tell me that other projects deleted the libs from their repository so we should do the same. But I can show you hundreds and thousands of projects not going that road and I tell you we shouldn't do it either. So how are we going to resolve this? Fact is: I don't care about how struts, commons or any other project in the world handles their source repository. If one project starts to check in tarballs of their source files instead of single source files and if ten other projects are stupid enough to follow, will we do the same because it's the latest trend and there are 11 others doing it? It's fine to collect ideas and inspiration from other projects but it's the best solution for the MyFaces build that matters! And so far I have not seen any argument it this discussion that convinces me eliminating the jars from the repository is a good thing. Oliver >sean > >On 6/22/05, Oliver Rossmueller <[EMAIL PROTECTED]> wrote: > > >>-1 on that. Please don't make the build more complex than needed. Not >>any stuff that seems to be cool to implement should be implemented. >> >>What's your problem with having the required libs in the repository? For >>me there are advantages only: >> >>- one source fits it all: you check out the svn module and have >>everything you need to build >>- the libs are versioned with the code which depends on the libs >>- you have everything maintained in one place, the svn repository; no >>need for external jar repositories or stuff like that >>- no build is blocked because the download of a required lib is not >>working for whatever reason (firewalls, network failures, ...) >> >>If you ever had the html of a http 500 page as the contents of a jar >>file in your maven repository instead of the required jar itself you >>know what I'm talking about. So do not try to imitate maven just by >>other means but follow the KISS principle and keep it simple, please. >> >>Oliver >> >> >>Manfred Geiler wrote: >> >> >> >>>yes, looks good >>>+1 for automatic download of jars >>> >>>-Manfred >>> >>> >>> >>>2005/6/21, Sean Schofield <[EMAIL PROTECTED]>: >>> >>> >>> >>> >>>>First off, thanks to James Mitchell (of the Struts team) who has been >>>>teaching me the wonders of svn:externals. I hope my SVN reorg will >>>>make him proud. :-) >>>> >>>>While James and I were discussing the Struts layout he also mentioned >>>>something interesting. They no longer keep any jar files in their >>>>repository. He has figured out a way to deal with the jar file >>>>dependencies that does *not* require Maven (ie. can be done from Ant.) >>>> >>>>I'm planning on doing something similar as part of the reorg. Check >>>>out the following steps that allow you to build struts 1.2 without >>>>specifying a single jar file in your properties ... >>>> >>>>$svn co >>>>https://svn.apache.org/repos/asf/struts/core/branches/STRUTS_1_2_BRANCH/ >>>>struts-1.2 >>>>$cd struts-1.2 >>>>$ant download-dependencies release >>>> >>>>Nice! I see no reason to deprive ourselves of the same cool build >>>>process ;-) Also, its possible to build using local jar files if that >>>>is your cup of tea (just don't run the download-dependencies target >>>>and specify the jar file locations in your local props file.) >>>> >>>>sean >>>> >>>> >>>> >>>> >>>> >>-- >>Oliver Rossmueller >>Software Engineer and IT-Consultant >>Hamburg, Germany >>http://www.rossmueller.com >> >> >> >> -- Oliver Rossmueller Software Engineer and IT-Consultant Hamburg, Germany http://www.rossmueller.com
