----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32189 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java <https://reviews.apache.org/r/16840/#comment60908> just minor comment, good to add out-of-sequence action list, like '3-5, 1' to check sorting. - Ryota Egashira On Jan. 14, 2014, 2:02 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 2:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
