> On Jan. 18, 2014, 12:49 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 363 > > <https://reviews.apache.org/r/16840/diff/2/?file=422334#file422334line363> > > > > You need to get max of endtime iterating through action list instead of > > just picking the last action's. And if one of them is still RUNNING better > > to do new Date(). > > > > For eg: You can have action 3 ending after action 5 if data was > > available later or if it was rerun. > > Purshotam Shah wrote: > Thanks for pointing out it. > > In place of making multiple DB call to get the status and last modified > time for each action. > > We make two calls. > 1. Get the running count for action list in range. > If any of them is running than end date = current date. > > 2. If none of them are running, make a DB call get max of last modified > date. > >
Thanks for pointing out it. In place of making multiple DB call to get the status and last modified time for each action. We make two calls. 1. Get the running count for action list in range. If any of them is running than end date = current date. 2. If none of them are running, make a DB call get max of last modified date. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32237 ----------------------------------------------------------- On Jan. 22, 2014, 1:24 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 1:24 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java e8c8f31 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 5d8d6df > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 6746922 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
