----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32594 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/16840/#comment61499> If there is only one action (which is most of the time), you can get the details of starttime and endtime from getCoordAction(tempList.get(0)) itself instead of making a db query. core/src/main/java/org/apache/oozie/CoordinatorEngine.java <https://reviews.apache.org/r/16840/#comment61501> Instead of making another query below to get endtime, here (new named query) get both id and endTime for a coord action and use a comparator on that to sort by endtime. core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/16840/#comment61500> There could be PREP or SUSPENDED workflows. Need to check for endtime = null instead of status core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java <https://reviews.apache.org/r/16840/#comment61498> Please do not write new JPAExecutor classes. Add to the QueryExecutor class. - Rohini Palaniswamy On Jan. 22, 2014, 1:24 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 1:24 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java e8c8f31 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 5d8d6df > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 6746922 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
