-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16840/#review32237
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/16840/#comment60966>

    You need to get max of endtime iterating through action list instead of 
just picking the last action's. And if one of them is still RUNNING better to 
do new Date().
    
    For eg: You can have action 3 ending after action 5 if data was available 
later or if it was rerun.


- Rohini Palaniswamy


On Jan. 14, 2014, 2:02 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16840/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 2:02 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1668
>     https://issues.apache.org/jira/browse/OOZIE-1668
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Coord log streaming start and end time should be of action list start and end 
> time
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
>   core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java 
> a29a07e 
> 
> Diff: https://reviews.apache.org/r/16840/diff/
> 
> 
> Testing
> -------
> 
> Refactored test-cases.
> Each test cases run a coord job which takes 5 min to complete.
> Made changes so that coord job is executed only once and all test cases use 
> that for validate.
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Reply via email to