> On Jan. 23, 2014, 4 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 376 > > <https://reviews.apache.org/r/16840/diff/1-3/?file=422275#file422275line376> > > > > Instead of making another query below to get endtime, here (new named > > query) get both id and endTime for a coord action and use a comparator on > > that to sort by endtime.
If list is huge, it need to get lastmodified date and status of each action and iterate see to status or find max lastmodified. Making two more DB call is simple and efficient. > On Jan. 23, 2014, 4 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java, line 162 > > <https://reviews.apache.org/r/16840/diff/3/?file=433916#file433916line162> > > > > There could be PREP or SUSPENDED workflows. Need to check for endtime = > > null instead of status If action is PREP or SUSPENDED, last modified date will tell when it was last modified. So i believe it's ok. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32594 ----------------------------------------------------------- On Jan. 23, 2014, 11:24 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 11:24 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java e8c8f31 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 5d8d6df > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 6746922 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
