> On Jan. 23, 2014, 4 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java, > > line 32 > > <https://reviews.apache.org/r/16840/diff/3/?file=433918#file433918line32> > > > > Please do not write new JPAExecutor classes. Add to the QueryExecutor > > class.
we discussed this yesterday. currently the QueryExecutor classes are meant to return beans - coord job bean, action bean etc. His queries here are returning a count and a maximum timestamp so cant fit in the query executor - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32594 ----------------------------------------------------------- On Jan. 22, 2014, 1:24 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 1:24 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java e8c8f31 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 5d8d6df > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 6746922 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
