> On Jan. 24, 2014, 1:15 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 356 > > <https://reviews.apache.org/r/16840/diff/3-4/?file=433917#file433917line356> > > > > Do a endtime=null instead of RUNNING check. There are other states like > > PREP, WAITING, etc apart from RUNNING
Puru pointed out that there is no endtime for coord action. And it should be ok to stream till last modified time. Refresh would anyway show new log statements. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16840/#review32681 ----------------------------------------------------------- On Jan. 23, 2014, 11:24 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16840/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 11:24 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1668 > https://issues.apache.org/jira/browse/OOZIE-1668 > > > Repository: oozie-git > > > Description > ------- > > Coord log streaming start and end time should be of action list start and end > time > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleEngine.java e8c8f31 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 5d8d6df > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionModifiedDateForRangeJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionRunningCountForRangeJPAExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 6746922 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > a29a07e > > Diff: https://reviews.apache.org/r/16840/diff/ > > > Testing > ------- > > Refactored test-cases. > Each test cases run a coord job which takes 5 min to complete. > Made changes so that coord job is executed only once and all test cases use > that for validate. > > > Thanks, > > Purshotam Shah > >
