On Wed, Mar 3, 2010 at 8:34 AM, Steve Huston <shus...@riverace.com> wrote: >> -----Original Message----- >> From: Gordon Sim [mailto:g...@redhat.com] >> Sent: Tuesday, March 02, 2010 7:20 AM >> To: dev@qpid.apache.org >> Subject: Re: Vote for 0.6 Release (Really) >> ... >> > On the .csproj files, I would guess that they probably do need a >> > licence, and if most of them already include it then it >> seems sensible >> > to do the rest and finish the job. >> >> Seems sensible. Is someone willing to volunteer to do that? > > Who's working on the .NET client these days? Has it been tested? > >> Following >> Rajiths comments I'm not sure what the right approach is. There are >> certainly other csproj files with the license in at the top >> of the file - do these cause problems for MSVC? > > No, as long as the inserted XML doesn't step on a special marker char > which may be at the very start of the file. I checked a few of the > dotnet csproj files and they didn't have that marker anyway, so there > should be no problem dropping the license into an XML comment. Just make > sure to try a build before committing and things should be fine.
I have no issues adding the license header, but I don't have a way of testing it out. Last time I did it, I had stepped on the almigty special marker and Steve had to work it out. So I believe somebody from the .NET project needs to do this and verify that everything is fine. > -Steve > > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/ --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
