I don't see this as a requirement for Royale's success, at least right now. How many bytes will we save by using YUI given that much of the CSS will be written by us committers? IMO, there are much bigger fish to fry. We control what we emit already, so YUI seems like over-kill. It will result in reading and writing of the CSS twice on each compile. Seems like you could take 2 or 3 YUI optimizations and get our current CSS Emitter to do them and that would be good enough.
My 2 cents, -Alex On 4/9/18, 2:13 AM, "[email protected] on behalf of Carlos Rovira" <[email protected] on behalf of [email protected]> wrote: >Hi, > >yesterday I was looking how to minify CSS in js-release. I put all the >wiring so we can process the final CSS js-release version. To see is >working I just put a basic break line removal, but this needs to be a full >CSS minification. > >in Java I see all people use YUI compressor [1]. This library has BSD >license [2]. >How BSD license relates to this Apache project? can we use that code or is >forbidden to us? > >If we can use it, problem solved and we can just add this dependency to >the >project to have a full css minifcation on release CSS >In case we can't use it, what could we do? should we code our own? this >seems something out of scope for us. > >The issue is this [3] > >Let me know what's your thoughts on this > >thanks > > >[1] >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fyui.github >.io%2Fyuicompressor%2Fcss.html&data=02%7C01%7Caharui%40adobe.com%7C9a0b7fc >80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636 >588620454020384&sdata=CNL%2BRwSU10MlkXfz2RSWvgGLIFliDSyNwkvX2c1LRHY%3D&res >erved=0 >[2] >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co >m%2Fyui%2Fyuicompressor%2Fblob%2Fmaster%2FLICENSE.TXT&data=02%7C01%7Caharu >i%40adobe.com%7C9a0b7fc80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c >178decee1%7C0%7C0%7C636588620454020384&sdata=%2FaQ6sPS6I0NyRvURDzMV%2F00GL >gFFEYu%2Bi9Hns0%2BxwCA%3D&reserved=0 >[3] CSS file must be minified in js-release ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c >om%2Fapache%2Froyale-compiler%2Fissues%2F39&data=02%7C01%7Caharui%40adobe. >com%7C9a0b7fc80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178decee1% >7C0%7C0%7C636588620454020384&sdata=bBByH28oNIIat2LWDYacivvUU2Bc7IjZII3zTO1 >xZOs%3D&reserved=0> > ><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c >om%2Fapache%2Froyale-compiler%2Fissues%2F39&data=02%7C01%7Caharui%40adobe. >com%7C9a0b7fc80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178decee1% >7C0%7C0%7C636588620454020384&sdata=bBByH28oNIIat2LWDYacivvUU2Bc7IjZII3zTO1 >xZOs%3D&reserved=0>-- >Carlos Rovira >https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2 >Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C9a0b7fc80136437e578e08d5 >9dfa3d6d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588620454020384&s >data=yMVJMpLWhfinA3FrYepcAhb4RCif6mNGooLFEb7DeWU%3D&reserved=0
