Yes, YUI does lots of things, but how often are folks going to write the
CSS it can optimize?  If you change our emitter so that it removes line
breaks, last semicolon, and most comments, everything else YUI can do will
likely have minimal effect.

If YUI is BSD it can be used, but I personally do not want to take the
time to verify that ALL of YUI is BSD compliant, update the builds,
LICENSE, etc, when the net benefit might be that someone was lazy about
margins and YUI saved them 20 bytes.  If that's where you want to spend
your energy, that's fine, but I really think we have more important things
to do.

My 2 cents,
-Alex

On 4/9/18, 10:37 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
<carlos.rov...@gmail.com on behalf of carlosrov...@apache.org> wrote:

>Hi Alex,
>
>I don't see it as a long term solution. As you said we can put some of the
>things, but if you see at the CSSCompressor code in YUI [1], there's so
>much done there. If you say me that YUI license is not compatible with us,
>that's ok, we can't use it so we need other solution (maybe yours for now
>or maybe someone could point to some library that is compatible with us).
>
>For our success...well, this is the kind of things that are very visible
>since are 1 of 4 files that we produce in release mode. People will open
>it
>to find a non minified CSS, so for me is not critical, since it works now,
>but it's what people uses to say "that royale project is not serious, you
>only have to take a look at the css they produce" since it will be bad for
>us (it's like a bad designed site, or things doesn't looking professional,
>are the kind of things that first enters your eyes, and can make all the
>hard work behind useless).
>
>about time on compilation, how many time will be spend in release mode?
>1-2...10 secs? don't think something valuable, taking into account that
>you
>use to develop in debug mode (that doesn't make this) and only in for
>release you'll enable it...
>
>[1]
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fyui%2Fyuicompressor%2Fblob%2Fmaster%2Fsrc%2Fcom%2Fyahoo%2Fplatform%2Fy
>ui%2Fcompressor%2FCssCompressor.java&data=02%7C01%7Caharui%40adobe.com%7Ca
>5dfecda12d24b0c92b308d59e40b018%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0
>%7C636588923038330549&sdata=KgvIPVTV3r1LzlevMUi9hNgT8v4jx5shdNaTMyf9qV8%3D
>&reserved=0
>
>
>2018-04-09 18:34 GMT+02:00 Alex Harui <aha...@adobe.com.invalid>:
>
>> I don't see this as a requirement for Royale's success, at least right
>> now.  How many bytes will we save by using YUI given that much of the
>>CSS
>> will be written by us committers?  IMO, there are much bigger fish to
>>fry.
>>  We control what we emit already, so YUI seems like over-kill.  It will
>> result in reading and writing of the CSS twice on each compile.  Seems
>> like you could take 2 or 3 YUI optimizations and get our current CSS
>> Emitter to do them and that would be good enough.
>>
>> My 2 cents,
>> -Alex
>>
>> On 4/9/18, 2:13 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira"
>> <carlos.rov...@gmail.com on behalf of carlosrov...@apache.org> wrote:
>>
>> >Hi,
>> >
>> >yesterday I was looking how to minify CSS in js-release. I put all the
>> >wiring so we can process the final CSS js-release version. To see is
>> >working I just put a basic break line removal, but this needs to be a
>>full
>> >CSS minification.
>> >
>> >in Java I see all people use YUI compressor [1]. This library has BSD
>> >license [2].
>> >How BSD license relates to this Apache project? can we use that code
>>or is
>> >forbidden to us?
>> >
>> >If we can use it, problem solved and we can just add this dependency to
>> >the
>> >project to have a full css minifcation on release CSS
>> >In case we can't use it, what could we do? should we code our own? this
>> >seems something out of scope for us.
>> >
>> >The issue is this [3]
>> >
>> >Let me know what's your thoughts on this
>> >
>> >thanks
>> >
>> >
>> >[1]
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fyui.github
>> >.io%2Fyuicompressor%2Fcss.html&data=02%7C01%7Caharui%40adobe.com
>> %7C9a0b7fc
>> >80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%7C0%7C0%7C636
>> >588620454020384&sdata=CNL%2BRwSU10MlkXfz2RSWvgGLIFliDSyN
>> wkvX2c1LRHY%3D&res
>> >erved=0
>> >[2]
>> >https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.co
>> >m%2Fyui%2Fyuicompressor%2Fblob%2Fmaster%2FLICENSE.TXT&
>> data=02%7C01%7Caharu
>> >i%40adobe.com%7C9a0b7fc80136437e578e08d59dfa
>> 3d6d%7Cfa7b1b5a7b34438794aed2c
>> >178decee1%7C0%7C0%7C636588620454020384&sdata=%
>> 2FaQ6sPS6I0NyRvURDzMV%2F00GL
>> >gFFEYu%2Bi9Hns0%2BxwCA%3D&reserved=0
>> >[3] CSS file must be minified in js-release
>> ><https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.c
>> >om%2Fapache%2Froyale-compiler%2Fissues%2F39&data=
>> 02%7C01%7Caharui%40adobe.
>> >com%7C9a0b7fc80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%
>> >7C0%7C0%7C636588620454020384&sdata=bBByH28oNIIat2LWDYacivvUU2Bc7I
>> jZII3zTO1
>> >xZOs%3D&reserved=0>
>> >
>> ><https://na01.safelinks.protection.outlook.com/?url=
>> https%3A%2F%2Fgithub.c
>> >om%2Fapache%2Froyale-compiler%2Fissues%2F39&data=
>> 02%7C01%7Caharui%40adobe.
>> >com%7C9a0b7fc80136437e578e08d59dfa3d6d%7Cfa7b1b5a7b34438794aed2c178de
>> cee1%
>> >7C0%7C0%7C636588620454020384&sdata=bBByH28oNIIat2LWDYacivvUU2Bc7I
>> jZII3zTO1
>> >xZOs%3D&reserved=0>--
>> >Carlos Rovira
>> >https://na01.safelinks.protection.outlook.com/?url=
>> http%3A%2F%2Fabout.me%2
>> >Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%
>> 7C9a0b7fc80136437e578e08d5
>> >9dfa3d6d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>> 7C636588620454020384&s
>> >data=yMVJMpLWhfinA3FrYepcAhb4RCif6mNGooLFEb7DeWU%3D&reserved=0
>>
>>
>
>
>-- 
>Carlos Rovira
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2
>Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca5dfecda12d24b0c92b308d5
>9e40b018%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636588923038330549&s
>data=GHFRlE7Cy2YlmMiw92pouSkENtljRRvY%2Fi4syRzwPIY%3D&reserved=0

Reply via email to