Ok Piotr, now I understand. I'm not doing browser check in our app since our client knows the versions we support and the tablets their workforce use is controlled. We can do as well some checking logic to plug in royale, but my email was more about giving flexibility to users that want to do that or output any other js or html code they want. Browser checking is just one of them.
Thanks! El mar., 27 ago. 2019 a las 10:46, Piotr Zarzycki (< [email protected]>) escribió: > Carlos, > > I don't refer to the compiler. As you can see in the code it is an attempt > of checking whether application is compatible with web browser. [1] Are you > doing that in your app ? > > If (browserversion < 44) > { > display something to the user > } > > If not how would you do that ? > > [1] https://apache.github.io/royale-docs/component-sets/jewel.html > > Thanks, > Piotr > > wt., 27 sie 2019 o 10:43 Carlos Rovira <[email protected]> > napisał(a): > > > Hi Piotr, sorry but I don't catch what you're trying to say. Sorry :? > > Anyway my proposal could not be the right one. Maybe others could bring > > other one that works better. > > The problem is that compiler output is currently very restrictive, and > > doing some little changes there users > > could extend their available options in custom html templates. > > > > El mar., 27 ago. 2019 a las 10:37, Piotr Zarzycki (< > > [email protected]>) escribió: > > > > > Carlos, > > > > > > Do you check in your application browser compatibility with Jewel ? How > > > would you do this if you would like to display something if browser is > > not > > > compatible ? > > > > > > Thanks, > > > Piotr > > > > > > wt., 27 sie 2019 o 10:34 Carlos Rovira <[email protected]> > > > napisał(a): > > > > > > > Hi Chris, > > > > > > > > Searching in royale-compiler, that line seems to be generated in > > > > MXMLRoyalePublisher.java > > > > line 917 on getTemplateBody method > > > > > > > > maybe the actual way compiler deal with this is a bit restricted, and > > we > > > > can update that part including the <script> tags in the html template > > and > > > > making ${body} only outputs "new App.start();", so people could > switch > > to > > > > its own "htmlTemplate" changing that to something like this: > > > > > > > > <script type="text/javascript"> > > > > royaleCompatibility = new RoyaleCompatibility(); > > > > if (royaleCompatibility.isCompatible) { > > > > ${body} > > > > } else { > > > > royaleCompatibility.displayIncompatibilityText(); > > > > } > > > > </script> > > > > > > > > Thoughts? > > > > > > > > Carlos > > > > > > > > > > > > > > > > El mar., 27 ago. 2019 a las 10:10, Chris Velevitch (< > > > > [email protected]>) escribió: > > > > > > > > > Where is the value of "${body}" defined? When I build a javascript > > app, > > > > the > > > > > following code is inserted there:- > > > > > > > > > > <script> > > > > > new MyApp().start(); > > > > > </script> > > > > > > > > > > I want to be able to insert additional code there like:- > > > > > > > > > > <script type="text/javascript"> > > > > > royaleCompatibility = new RoyaleCompatibility(); > > > > > if (royaleCompatibility.isCompatible) { > > > > > new MyApp().start(); > > > > > } else { > > > > > royaleCompatibility.displayIncompatibilityText(); > > > > > } > > > > > </script> > > > > > > > > > > > > > > > How do I do that? > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: *https://www.patreon.com/piotrzarzycki > > > <https://www.patreon.com/piotrzarzycki>* > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>* > -- Carlos Rovira http://about.me/carlosrovira
