Hi all. So far, we got 1(+1 binding) and 3(+1 non-binding). Thanks for taking time to try out RC4. But I think we need more +1.
Please take time to try out our RC4 then give any feedback and vote. I will wait more days before closing out this vote thread until either objection or sufficient votes. On Fri, Sep 23, 2016 at 3:00 PM Sergio Fernández <wik...@apache.org> wrote: > On Fri, Sep 23, 2016 at 12:51 AM, Jong Wook Kim <jongw...@nyu.edu> wrote: > > > I wrote that section in the README.md in mind that the majority will > > download the binary distribution which will contain the content in the > > subdirectory, > > > > The section “Building from the source” specifies that the distribution > > will be created in target/apache-s2graph-$version-incubating-bin. > > > > So I don’t think this is a blocker, but I agree that README.md can be > even > > more specific and it would be nice if start-s2graph.sh prints a helpful > > message if it is launched in the source root. > > > > No no, the mistake was completely on my side, I just wanted to provide > feedback from outside of the project development. Of course this is not > blocking the release, it's just a comment. > > > > > > > > On Sep 22, 2016, at 6:02 AM, Sergio Fernández <wik...@apache.org> > wrote: > > > > > > On Thu, Sep 22, 2016 at 11:56 AM, Kim, Min-Seok <mskim....@gmail.com> > > wrote: > > >> > > >> To Sergio, > > >> > > >> The commands will work on > > >> > `/path/to/incubator-s2graph/target/apache-s2graph-0.1.0-incubating-bin` > > >> after `sbt package`. > > >> > > > > > > Of course! > > > > > > Then the README needs to remark that to avoid people to get confused, > > like > > > it happened to me. > > > > > > Thanks! > > > > > > -- > > > Sergio Fernández > > > Partner Technology Manager > > > Redlink GmbH > > > m: +43 6602747925 > > > e: sergio.fernan...@redlink.co > > > w: http://redlink.co > > > > > > > -- > Sergio Fernández > Partner Technology Manager > Redlink GmbH > m: +43 6602747925 > e: sergio.fernan...@redlink.co > w: http://redlink.co >
