----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review83288 -----------------------------------------------------------
As mentioned in the other subtask reviews, it would be very useful to provide an overwrite option for import (ie, replace the existing policies with the new ones). Also we should add this for generalized privilege model as well, can be addressed via a separate task or followup ticket. Are we audting the import and export actions on Sentry service side ? A few additional comments/suggestions below sentry-provider/sentry-provider-db/pom.xml <https://reviews.apache.org/r/31071/#comment134195> Junit should be test scope sentry-provider/sentry-provider-db/pom.xml <https://reviews.apache.org/r/31071/#comment134196> Can we avoid this. It's better to keep the providers isolated. If there's some common method, then please consider moving that to provider-common sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java <https://reviews.apache.org/r/31071/#comment134321> Shouldn't the Export be restricted to admin users ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java <https://reviews.apache.org/r/31071/#comment134322> Same as previous, import should be restricted to admin users sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFileConstants.java <https://reviews.apache.org/r/31071/#comment134323> Perhaps this class could be moved to common package - Prasad Mujumdar On March 9, 2015, 2:50 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 2:50 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml 6116cd5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 7a9f0df > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 44681ca > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > b4c49da > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryTestImportExportUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFileConstants.java > b2bc531 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFiles.java > f303294 > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
