> On June 1, 2015, 8:24 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java, > > line 896 > > <https://reviews.apache.org/r/31071/diff/4/?file=964676#file964676line896> > > > > These utility functions should not be duplicated as much as possible > > and should stay in utility classes or SentryStore.
Thanks for the comments, create a new utility class SentryServiceUtil for these utility functions. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review85683 ----------------------------------------------------------- On June 2, 2015, 8:32 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:32 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 05cbfb6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > c3c1907 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 30792f3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
