> On June 17, 2015, 7:48 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java, > > line 76 > > <https://reviews.apache.org/r/31071/diff/5/?file=976386#file976386line76> > > > > Instead of test1/2/3 could it be possible to give it a meaningful name?
For this problem, I'm sorry to use these confusing method name, but I use a lot of commets before each method to describe the purpose of the test case. > On June 17, 2015, 7:48 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java, > > line 382 > > <https://reviews.apache.org/r/31071/diff/5/?file=976386#file976386line382> > > > > One more test case: all, *, select, insert, however specify > > no-overwriting, so the permissions will be kept as before. The overwriting for privilege and for import are the different things, for privilege, the all, * will always overwrite the select and insert for the same object. For import, for example: 1st import: role1=privilege1,privilege2 role2=privilege1 2nd import: role1=privilege2,privilege3 role3=privilege1 if do the import with overwriting, the result will be: role1=privilege2,privilege3 role2=privilege1 role3=privilege1 if without overwriting, the result will be: role1=privilege1, privilege2,privilege3 role2=privilege1 role3=privilege1 I also add one test case about import select/insert first, and then import all, check the overwriting for the privilege. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review88255 ----------------------------------------------------------- On June 19, 2015, 1:32 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 1:32 a.m.) > > > Review request for sentry and Anne Yu. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 05cbfb6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > c3c1907 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 30792f3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
