----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review88255 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 56) <https://reviews.apache.org/r/31071/#comment140677> White space sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 72) <https://reviews.apache.org/r/31071/#comment140678> role2? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 73) <https://reviews.apache.org/r/31071/#comment140679> role3? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 76) <https://reviews.apache.org/r/31071/#comment140680> Instead of test1/2/3 could it be possible to give it a meaningful name? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 142) <https://reviews.apache.org/r/31071/#comment140686> exceptedMappingData seems like policyFileMappingData1 + policyFileMappingData2. Maybe instead of redefining it, just combinte policyFileMappingData1 and 2. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 161) <https://reviews.apache.org/r/31071/#comment140688> Call import twice, and there has duplicate (or overlapping) groups; sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 382) <https://reviews.apache.org/r/31071/#comment140697> One more test case: all, *, select, insert, however specify no-overwriting, so the permissions will be kept as before. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java (line 383) <https://reviews.apache.org/r/31071/#comment140698> One more test case: with overlapping privileges, all,*, shadowing insert,select, and specify overwriting in importPolicy. - Anne Yu On June 2, 2015, 8:32 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:32 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 05cbfb6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > c3c1907 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 30792f3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
