> On May 12, 2015, 4:49 a.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/pom.xml, line 97 > > <https://reviews.apache.org/r/31071/diff/3/?file=888611#file888611line97> > > > > Can we avoid this. It's better to keep the providers isolated. If > > there's some common method, then please consider moving that to > > provider-common
Create new JIRA, sentry-740: Move the class PolicyFileConstants and KeyValue to provider-common. > On May 12, 2015, 4:49 a.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFileConstants.java, > > line 27 > > <https://reviews.apache.org/r/31071/diff/3/?file=888617#file888617line27> > > > > Perhaps this class could be moved to common package Move the class PolicyFileConstants and KeyValue to provider-common - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review83288 ----------------------------------------------------------- On March 9, 2015, 2:50 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 2:50 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml 6116cd5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 7a9f0df > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 44681ca > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > b4c49da > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryTestImportExportUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFileConstants.java > b2bc531 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFiles.java > f303294 > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
