----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31071/#review85683 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java <https://reviews.apache.org/r/31071/#comment137387> typo: poicy => policy? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java <https://reviews.apache.org/r/31071/#comment137389> These utility functions should not be duplicated as much as possible and should stay in utility classes or SentryStore. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java <https://reviews.apache.org/r/31071/#comment137895> Same comment about utility functions consolidation as above. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java <https://reviews.apache.org/r/31071/#comment137388> same typo "Poicy" sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java <https://reviews.apache.org/r/31071/#comment137928> Again, utility function to serialize TPrivilege, probably should remain in SentryStore or some other utility class? - Sravya Tirukkovalur On May 20, 2015, 1:34 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31071/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 1:34 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryService for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 7a9f0df > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 44681ca > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 30792f3 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31071/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
