Sent from my Sony Xperia™ smartphone

---- Martin Desruisseaux wrote ----

>What about making it a dialog box instead than part of the CRS pane? A later 
>version could have two tabs: one which is the current one, and one for the 
>Well Known Text. I'm not suggest to do that now; just planing for future 
>evolution.

CRSEditor can be embedded anywhere, even in dialog box. 

> As a side note, I see many exceptions like below when running the 
> application. Could you fix?

It's related to spinners being initialized from fxml. This exception was being 
thrown at fxml.load() time. I tried many options but so far I have partially 
solved the problem. 

> Another note: the package name should be changed in order to start with 
> "org.apache.sis". It could be for instance "org.apache.sis.desktop" (I 
> suggest to avoid "client" since it may have other meaning unrelated to 
> desktop application).

I have changed it to org.apache.sis.desktop, similar to the sis-console module. 
The artifact would be a part of "applications" submodule. 

When editing CRS when I have to update certain fields, what pattern needs to be 
followed? Do I 
* call setValue if available 
* create a new object by calling constructor 
* use a factory method like DatumFactory.createPrimeMeridian 

Also once the CRS is edited where is it supposed to be stored? 

Regards 
Siddhesh Rane 

Reply via email to