>   next if ($answer->type ne 'A' && $answer->type ne 'TXT');
>   # skip any A record that isn't on 127/8
>   next if ($answer->type eq 'A' && $answer->rdatastr !~ /^127\./);
>
> Shouldn't that prevent what Vance's comment #23 debug log output shows
even if
> the wrong query's results were associated with a SURBL lookup? How could a
> non-127 ip address get passed in to the URIRBL processing? The answer to
that

Well, trivially from those two lines (if I understand perl expressions well
enough) we will fall through with a 'TXT' record containing anything as well
as an A record containing '127.'
I assume however there will be a further check for TXT records and they will
be processed differently.

(I personally would have coded that first test with eq's and an || to make
it easier to understand, but perhaps perl convention is to use reversed
tests.)

Reply via email to