----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review67856 -----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java <https://reviews.apache.org/r/29849/#comment111946> while youa re please fix the , it should be Too few? not sure I understand this public enum MatcherError implements ErrorCode { MATCHER_0000("To few Schemas provided."), ; Second, why only change this to an exception in Name and not in LocationMatcher? connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java <https://reviews.apache.org/r/29849/#comment111948> thanks for the boolean clean up, simple if/else does the shop. connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java <https://reviews.apache.org/r/29849/#comment111949> are ew sure we want to nuke this test case? - Veena Basavaraj On Jan. 13, 2015, 7:14 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:14 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > 624fa7b > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 76ff0da > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
