----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review67859 -----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java <https://reviews.apache.org/r/29849/#comment111951> fix the comment in LocationMatcher /** * Convert data according to FROM schema to data according to TO schema. This is * done based on column location, Data in first column in FROM goes into first * column in TO, etc., if TO schema has more fields and they are "nullable", * their values will be set to null. If TO schema has extra non-null fields, we * will throw an exception. */ connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java <https://reviews.apache.org/r/29849/#comment111955> Overall I dont understand why even from schema is maintained in the Matcher since it never even used, Another ticket to clean up this. At the end of the day what is important is to schema so we can write the data adapting to it in one of the many ways we want to do matching. connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java <https://reviews.apache.org/r/29849/#comment111953> /** * Convert data according to FROM schema to data according to TO schema. This is * done based on column name, If TO schema has more fields and they are * "nullable", their values will be set to null. If TO schema has extra non-null * fields, we will throw an exception. */ * fix the comment since null adding is now been removed - Veena Basavaraj On Jan. 13, 2015, 7:14 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 7:14 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > 624fa7b > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 76ff0da > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
