> On Jan. 13, 2015, 11:45 p.m., Veena Basavaraj wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java, > > line 47 > > <https://reviews.apache.org/r/29849/diff/1/?file=818950#file818950line47> > > > > fix the comment in LocationMatcher > > > > > > /** > > * Convert data according to FROM schema to data according to TO > > schema. This is > > * done based on column location, Data in first column in FROM goes > > into first > > * column in TO, etc., if TO schema has more fields and they are > > "nullable", > > * their values will be set to null. If TO schema has extra non-null > > fields, we > > * will throw an exception. > > */
No. See `tryFillNullInArrayForUnexpectedColumn()` > On Jan. 13, 2015, 11:45 p.m., Veena Basavaraj wrote: > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java, > > line 16 > > <https://reviews.apache.org/r/29849/diff/1/?file=818952#file818952line16> > > > > /** > > * Convert data according to FROM schema to data according to TO > > schema. This is > > * done based on column name, If TO schema has more fields and they are > > * "nullable", their values will be set to null. If TO schema has extra > > non-null > > * fields, we will throw an exception. > > */ > > * > > > > > > fix the comment since null adding is now been removed No. See `tryFillNullInArrayForUnexpectedColumn()` - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29849/#review67859 ----------------------------------------------------------- On Jan. 13, 2015, 11:14 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29849/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:14 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1988 > https://issues.apache.org/jira/browse/SQOOP-1988 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java > d92723e > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java > 36ac5a5 > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java > 7cbc39f > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java > 624fa7b > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java > 76ff0da > > Diff: https://reviews.apache.org/r/29849/diff/ > > > Testing > ------- > > Existing tests passed > > > Thanks, > > Qian Xu > >
