> On Jan. 13, 2015, 7:45 a.m., Veena Basavaraj wrote:
> > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java,
> > line 47
> > <https://reviews.apache.org/r/29849/diff/1/?file=818951#file818951line47>
> >
> > Overall I dont understand why even from schema is maintained in the
> > Matcher since it never even used,
> >
> > Another ticket to clean up this.
> >
> > At the end of the day what is important is to schema so we can write
> > the data adapting to it in one of the many ways we want to do matching.
>
> Qian Xu wrote:
> FROM schema is required by name matching.
>
> Veena Basavaraj wrote:
> can you point me to the code where it is using it,
nm i found it, its here, we already do this in the schema now since we need it
for avro and JSON, so another place to clean up this code.
for (Column fromCol : getFromSchema().getColumnsList()) {
fromColNameIndexMap.put(fromCol.getName(), fromIndex);
fromIndex++;
}
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29849/#review67859
-----------------------------------------------------------
On Jan. 13, 2015, 8:13 a.m., Qian Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29849/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2015, 8:13 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1988
> https://issues.apache.org/jira/browse/SQOOP-1988
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/LocationMatcher.java
> d92723e
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/Matcher.java
> 36ac5a5
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/MatcherError.java
> 577b091
>
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/matcher/NameMatcher.java
> 7cbc39f
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestLocationMatcher.java
> 624fa7b
>
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/matcher/TestNameMatcher.java
> 76ff0da
>
> Diff: https://reviews.apache.org/r/29849/diff/
>
>
> Testing
> -------
>
> Existing tests passed
>
>
> Thanks,
>
> Qian Xu
>
>
