Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r13929896
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -85,6 +92,34 @@ public void fail(Object msgId) {
_spoutMsg.setId(msgId);
querySubprocess();
}
+
+ private void handleMetrics(ShellMsg shellMsg) {
+ //get metric name
+ String name = shellMsg.getMetricName();
+ if (name.isEmpty()) {
+ throw new RuntimeException("Receive Metrics name is empty");
+ }
+
+ //get metric by name
+ IMetric iMetric = _context.getRegisteredMetricByName(name);
+ if (iMetric == null) {
+ throw new RuntimeException("Not find metric by name["+name+"]
");
--- End diff --
Perhaps "Could not find metric by name["+name+"] " instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
